v3 - calculator salary data input for Sanity Studio #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
mathiazom
force-pushed
the
feat/v3-dynamic-salary-data-for-calculator
branch
from
d56572f to
948e1cb
Compare
mathiazom
force-pushed
the
feat/v3-dynamic-salary-data-for-calculator
branch
from
c646fce to
56c511b
Compare
mathiazom
force-pushed
the
feat/v3-dynamic-salary-data-for-calculator
branch
from
56c511b to
e1e1d12
Compare
anemne
reviewed
Sep 2, 2024
anemne
reviewed
Sep 2, 2024
anemne
reviewed
Sep 2, 2024
anemne
reviewed
Sep 2, 2024
anemne
reviewed
Sep 2, 2024
anemne
reviewed
Sep 2, 2024
anemne
reviewed
Sep 2, 2024
mathiazom
force-pushed
the
feat/v3-dynamic-salary-data-for-calculator
branch
from
cd95c7d to
ce467ca
Compare
since there is no way to specify a fixed ordering (only custom user order)
This allows us to still provide the filename to screen readers after file upload. The file will now be cleared when the user starts to upload a new file (note that the file will also be cleared if the user only cancels the file dialog without uploading a file).
To clarify that a file has already been uploaded, and a new upload will override these values
mathiazom
force-pushed
the
feat/v3-dynamic-salary-data-for-calculator
branch
from
87243e2 to
88fda1b
Compare
christinaroise
approved these changes
Sep 10, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further explanation is found here: #523
Added salaries data to the
compensationsdocument schema. Each year has a JSON-encoded object of examinationYear and salary pairs (see picture below).The Studio input for a year's salaries consists of an upload button for loading data from a .csv file. Once loaded, the individual salaries can be edited via number inputs.
Salary data from Studio is not yet connected to the salary calculator.
Visual Overview (Image/Video)
List of per-year salary data:
Editable salaries after .csv upload
Internally stored as JSON objects, as seen from Studio Vision:
User feedback for common error states is provided as toasts, for example invalid data:
Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: